Simplify “**” handling using brace expansion (fixes #11110)#11125
Merged
gnodet merged 1 commit intoapache:masterfrom Sep 17, 2025
Merged
Simplify “**” handling using brace expansion (fixes #11110)#11125gnodet merged 1 commit intoapache:masterfrom
gnodet merged 1 commit intoapache:masterfrom
Conversation
- Convert "**/" to "{**/,}" after escaping special chars (including braces)
- Treat user braces literally in Maven-style patterns; alternation remains with explicit glob:
- Add tests for literal braces and explicit glob alternation
Fixes apache#11110
gnodet
changed the title
desruisseaux
approved these changes
Sep 16, 2025
desruisseaux
pushed a commit
to Geomatys/maven
that referenced
this pull request
Dec 14, 2025
This simplification appears to also fix a bug.
Contributor
desruisseaux
pushed a commit
to Geomatys/maven
that referenced
this pull request
Dec 15, 2025
- Convert "**/" to "{**/,}" after escaping special chars (including braces)
- Treat user braces literally in Maven-style patterns; alternation remains with explicit glob:
- Add tests for literal braces and explicit glob alternation
Fixes apache#11110
desruisseaux
pushed a commit
that referenced
this pull request
Dec 16, 2025
- Convert "**/" to "{**/,}" after escaping special chars (including braces)
- Treat user braces literally in Maven-style patterns; alternation remains with explicit glob:
- Add tests for literal braces and explicit glob alternation
Fixes #11110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies support for the ** wildcard and clarifies brace handling.
What changes
**/to{**/,}after escaping special characters (including braces){and}in Maven-style patterns so braces are treated literallyglob:syntaxglob:alternationWhy
**(“zero or more directories”) without custom logic[ ]and{ }are escaped in Maven-style patternsglob:is usedBehavior notes
**continues to mean “0+ directories”;**/is normalized to{**/,}so both the current directory and subdirectories matchglob:prefix, brace alternation remains supported per NIO glob rulesTests
testLiteralBracesAreEscapedInMavenSyntax: verifies that files with literal braces match with Maven-style patternstestBraceAlternationOnlyWithExplicitGlob: verifies alternation works only withglob:Fixes #11110